[U-Boot] [PATCH] nand: fix up badblock skipping

[Jiri Valek]

From: Jiri Valek <***@2n.cz>

Currently the badblock skipping fails. SPL loader fails to boot from NAND.
End up on message "SPL: failed to boot from all boot devices"

Signed-off-by: Jiri Valek <***@seznam.cz>
---

drivers/mtd/nand/raw/mxs_nand_spl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
index 2d7bbe83cc..56618c95dc 100644
--- a/drivers/mtd/nand/raw/mxs_nand_spl.c
+++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
@@ -239,6 +239,7 @@ int nand_spl_load_image(uint32_t offs, unsigned int size, void *buf)
*/
while (is_badblock(mtd, offs, 1)) {
page = page + nand_page_per_block;
+ offs = offs + mtd.erasesize;
/* Check i we've reached the end of flash. */
if (page >= mtd->size >> chip->page_shift)
return -ENOMEM;

[Miquel Raynal]

Hi Jiri,

Post by Jiri Valek
Currently the badblock skipping fails. SPL loader fails to boot from NAND.
End up on message "SPL: failed to boot from all boot devices"
---
drivers/mtd/nand/raw/mxs_nand_spl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
index 2d7bbe83cc..56618c95dc 100644
--- a/drivers/mtd/nand/raw/mxs_nand_spl.c
+++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
@@ -239,6 +239,7 @@ int nand_spl_load_image(uint32_t offs, unsigned int size, void *buf)
*/
while (is_badblock(mtd, offs, 1)) {
page = page + nand_page_per_block;
+ offs = offs + mtd.erasesize;
/* Check i we've reached the end of flash. */
if (page >= mtd->size >> chip->page_shift)
return -ENOMEM;

Reviewed-by: Miquel Raynal <***@bootlin.com>

Thanks,
Miquèl

[Stefano Babic]

Hi Jiri, Miquel,

Post by Miquel Raynal
Hi Jiri,

Post by Jiri Valek
Currently the badblock skipping fails. SPL loader fails to boot from NAND.
End up on message "SPL: failed to boot from all boot devices"
---
drivers/mtd/nand/raw/mxs_nand_spl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
index 2d7bbe83cc..56618c95dc 100644
--- a/drivers/mtd/nand/raw/mxs_nand_spl.c
+++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
@@ -239,6 +239,7 @@ int nand_spl_load_image(uint32_t offs, unsigned int size, void *buf)
*/
while (is_badblock(mtd, offs, 1)) {
page = page + nand_page_per_block;
+ offs = offs + mtd.erasesize;
/* Check i we've reached the end of flash. */
if (page >= mtd->size >> chip->page_shift)
return -ENOMEM;

I agree that secto must be skipped, but implementation looks wrong. mtd
is a pointer, and the above line should be off + mtd->erasesize. Do you
build with it ? I tried to apply it, as expected it cannot be compiled
clean.

Best regards,
Stefano Babic