Discussion:
[U-Boot-Users] watchdog reset in mpc824x timer interrupt.
Gleb Natapov
2003-09-14 15:14:27 UTC
Permalink
Hello,

Attached patch makes timer_interrupt to perform watchdog reset on all
boards that support watchdog and not only for OXC.

CHANGELOG:
perform watchdog reset in mpc824x timer interrupt on all boards that have watchdog.

--
Gleb.
-------------- next part --------------
Index: cpu/mpc824x/interrupts.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/cpu/mpc824x/interrupts.c,v
retrieving revision 1.3
diff -u -r1.3 interrupts.c
--- cpu/mpc824x/interrupts.c 27 Jun 2003 21:32:33 -0000 1.3
+++ cpu/mpc824x/interrupts.c 14 Sep 2003 15:10:44 -0000
@@ -27,6 +27,7 @@
#include <asm/processor.h>
#include <asm/pci_io.h>
#include <commproc.h>
+#include <watchdog.h>
#include "drivers/epic.h"

/****************************************************************************/
@@ -149,15 +150,9 @@

timestamp++;

-#if defined(CONFIG_WATCHDOG)
+#if defined(CONFIG_WATCHDOG) || defined (CONFIG_HW_WATCHDOG)
if ((timestamp % (CFG_HZ / 2)) == 0) {
-#if defined(CONFIG_OXC)
- {
- extern void oxc_wdt_reset (void);
-
- oxc_wdt_reset ();
- }
-#endif
+ WATCHDOG_RESET ();
}
#endif /* CONFIG_WATCHDOG */
#if defined(CONFIG_SHOW_ACTIVITY) && defined(CONFIG_OXC)
Wolfgang Denk
2003-09-14 19:05:30 UTC
Permalink
Dear Gleb,
Post by Gleb Natapov
Attached patch makes timer_interrupt to perform watchdog reset on all
boards that support watchdog and not only for OXC.
Thanks, added. Will show up on CVS "soon" :-(

Best regards,

Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
I am not now, nor have I ever been, a member of the demigodic party.
-- Dennis Ritchie
Gleb Natapov
2003-09-15 07:00:05 UTC
Permalink
Hello Denk,

I've looked at timer_interrupt() on all Motorola CPUs and it seems it is
possible to move most of the code from cpu/$(CPU)/interrupt.c directory to
one common place (ppc_lib/interrupt.c for instance). Unfortunately I have only
MPC8245 CPU for testing.
Post by Wolfgang Denk
Dear Gleb,
Post by Gleb Natapov
Attached patch makes timer_interrupt to perform watchdog reset on all
boards that support watchdog and not only for OXC.
Thanks, added. Will show up on CVS "soon" :-(
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
I am not now, nor have I ever been, a member of the demigodic party.
-- Dennis Ritchie
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
--
Gleb.
Wolfgang Denk
2003-09-15 14:56:55 UTC
Permalink
Best regards,
Post by Gleb Natapov
I've looked at timer_interrupt() on all Motorola CPUs and it seems it is
possible to move most of the code from cpu/$(CPU)/interrupt.c directory to
one common place (ppc_lib/interrupt.c for instance). Unfortunately I have only
MPC8245 CPU for testing.
I can test on 8xx and 82xx.

Best regards,

Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
If the facts don't fit the theory, change the facts.
-- Albert Einstein
Gleb Natapov
2003-09-16 12:07:07 UTC
Permalink
Hello Wolfgang,

The attached patch moves most of the things related to timer interrupt to
ppc_lib/interrupts.c leaving only cpu specific code in cpu/$(CPU)/interrupts.c

I only checked it on MPC8245. It works for me.

Can you look at the patch please.

CHANGELOG:
Move most of the things related to timer interrupt to ppc_lib/interrupts.c

Best regards,
Post by Wolfgang Denk
Post by Gleb Natapov
I've looked at timer_interrupt() on all Motorola CPUs and it seems it is
possible to move most of the code from cpu/$(CPU)/interrupt.c directory to
one common place (ppc_lib/interrupt.c for instance). Unfortunately I have only
MPC8245 CPU for testing.
I can test on 8xx and 82xx.
begin 644 interrupts.patch.gz
M'XL("*#Y9C\``VEN=&5R<G5P<G,N<&%T8V@`[5U[=]K(DO\;?XJ:S+USP0(C
M\;*-)]D03!QV_;J`;V9V9HZ.+&2L#2`B"3]N)OO9MZJ[]4#HA8/GM?%)C%%W
M5S^JNKI^U=6ML7ES`Y6E?0Z5'V!LS=TQ/5A6KBW+K5Y;FCVNZM;$F+O5J3[>
MTT7*WB(F;:=2J227+-1DN5Z16Y7:`<ARNZZTF_M[LO<#DER7Y1U)DM)J$#0.
M*TH+E$:[66LW6FLT7K^&2JUV6*Z#1!]*'5Z_W@'Z,6^@*$FVY6JN9:OF?&P\
MP*N74'3,?QO6#6""?JO9#E0A\N0G^9=2:0<*JT5?@GRT`Y]WI!WI6_-F;-Q`
M]^+\;?]$[71'_7_U1S^J9Q?G_='%8$>ZL\PQ:+IKWIGNHSJSYB:2@>)R:LTG
MX)HSPW&UV:*T(WV*TAJ..J.KH7K:.]Z1"M2!HI\=_@[%[ML3]=U_8XMK)7B)
M#4(2A0*.E7IK:+9[;6 at N%$M'2-28(V-WI,_^G^-LQM\^SBSQ>YWS*XGKK%])
M#G at ***@XQ,(_;GX7T<D6SF-Y4Z,9\^:@IC/K'.<)?V'(IR:6L\N]8<8Y5EQ(P?
MSRZ.U>,WR+`A\N+.FFJN.37`G,VTA>K"+OYAH^@4_0<E5JY_=C8X6BE at +0YJ
M+9D5L198XCLJ67EESE3\;MDNY48Y<$T=S+D+SJUYXW*9E.)$A4N*D!+X1'+"
MYP,O^`KJ3'8*83J8Q5I at E=9"78PU=PPO699",?+X._A?^4&^X9PHP:]05.#[
M[Z%8:X#$&U8B(2SXT@?5W;71 at MUJ2#Y9CGC64,8<TFL]Z/1_77+]A'6I]9.$
ML-4J2 at .4>KM6:]</5X2M%B^Q40+9TJHT6^462/2!64E:"U-C[%J3R=20)":L
ML'4%`TC,G!OCHJ=EWEV\]ZF6TC6-(I="N at 8[J_+&JJQZ`QN?I'*D'6#M=&ZM
M>]5K;)&$5[,GJ%\_8=^%1"_GCCG!!@+I7R":3")3V:XOEM7]QL.#NO_P4$6J
MAFTO%ZX3%H#$+&%12,Q$/$6)4"K*(0F%W&C7Y'2A2"652SSJM7*K!A)^[#/A
M^-:<Z]/EV(#O=6LV6]B6OG?[*OI8FX_9TYU*=7>+/]6=RD[%Y\S8T&UC9E"G
M5-U:SMVC`EME<>*RKW"G39<&W*`<*D:KBK(S,W7;<@S=FH\=X-2VWSXA0"HN
MTE,4<54-9(DFPTYE8KCJS+&+)(JEG<JGG4IA)0=@XA%1*FC.##Q]7'PQN\$$
M^+O\`MKPXJ7]`HKXO01ME/6*M[SPHI_CVT$5XG-1_5J=HBV12MV at 4JS6J[64
M7$M,;Y%3R;U%+L7W%DNM]!8S1GK+B[)VI/>7&K!6:T)_ at VI%?REK*:B'4S7F
MVC6JG&!*A3LHAAB*'JMI23H;#M1>SR>$4LI[X<#-5)N0;<ASP+WF`%*`:P-%
MUV!RBM7L5,:FDU+GTF,C*BJ_VJ-P8^@7+I1!.WR;1"2)%/B&=&O0SFU/$-*W
M?A^P-Z8K^B&MIZBHP"!@W>[:G.=:.[RB'/?>7)V4X+OOX)O((M,YZY]T+LY[
M)_5ACZSIA8V5W11?K%;9AI,1S#1S#KJV=`SDTJ2-`G'PT*9?/\]?E/FR*:-U
MAXJQ<5`^X*LF\)^3T:!W,NAUCHN]T;O>X+PWJJG]\U%O,+BZ'*EGG>%_J9BA
M/\0G)%;8C"5R<JT1R#;71(ZN]1A;0,7$DE8IK&40`N!>Z],/*'E587F1_;,^
M?HF947>+-9\-*%:4WDY<3I?:5#07L_!F5OQFBFG(YT2TNA+3`-'Z$MC#IAY5
M&4P$+MPOB4W3AQ+C4:50\*?!6D-2)F?N9N#J;^RM5PQQM:Z9_\!EJ*&4&[C8
M[M?*BLQ1XBZ,;#1+<"3-V6+*6(6:R9I#!>86S`V<!*Z%J@'%4IM.'W'8]:6M
MN<8>E:WN")U'AI,=*(JBX]I+W05L.THS+GWT.Z2K2#VNSRS2$+X%1I8@'YNH
MZ?:^,^J^.[XX07KI^#`P_>/(7';[EY?=&E$I&`_8BCFWU1:ZN5CH-?5^3(TG
MO<BU!5\S"FO)Q15F?_;^#IGS7H.99GTF'<?9P!JD,F:$574P0,RFY&U8!LLE
M+\`5.L=XK)@G0D'Q"D_V2`3K79@"JD at I(@]<J\8+!41;R'`>CM[<<F]IUJ'X
MC2VX-?C2)(EF":F&+0]EIKT]6^C-5&L[)D/4UH[)$G46(?RJISL,T at GE\!@=
M$/R2\.-0:((JC>>J76W-R:RN!`_O-5>_'5N3B`W.&Q)YB(9.E>QUPW$L>]OF
M>:9IGL\J+VS9*B=J(`0]$'^"?JA2">X%#V\1M$RQO2[LBC]I<68Z:!?AX1'C
M4J-5WJ\C&CHL*YQ-PNI,JL*T/ZIWAN[\=#Y0^X-_#G\YXI-DIX*:_M324<_?
M+.<\+_+&M=S'A>%0:C73MO96&M at 024`(2K0#(-$6*C4OD@!_(<V#)"`$)=KM
MC7$$3#SS83,<`2$@T0Y at 1*2O.7`$^/9+'AP!(2`A>KN"(H0`]!B("-DQ at O&L
MPC6$`6D0`^(Q!JMFD`=GB*K)!%\'&I"!-)C#I;(-L,%,H#X:6&@"F<[*V`B5
M&(,?(!-`L"8GH8=-G:3DSD5U=AQ0`P0*8[XFDF(C$5HZS&M$8YINHL-&-CI$
MC'3>$LXP0(LP;!33<!5\IZUC+I'<_&;/T?'OF>9\$!L(8>,\U at K,%K<$^[8F
MMTA/2DJC658:'"7Y&A%__;*'BA5;<7YU>BJ*57Q>1%R'PE9BRI-D!$9DTP3=
M16,(V^8@:)O2N-_?&G.`:Y0-&2PRYKODR9M/#)P&MC7C).2]%2::CIAT6-QT
M;UGIT9L>UH$?P^Y`V-A\>D9,JB1S2HK+G&%_/4$@*XF;-I45:YI+IHI=1!M1
M_R!F1ABID&DN^^`8%1FNHF*L^WYGZ5D8A?(MK_UR8Q^9W5+*3<YK546EB`JT
M^&)N+5C^0!Q1EFW'W=,U6UU,%[9NPZ\OX?+T<M`=J*/>#Y=#E"_OZQFB92ZH
M5=)FCDM^D3#GNFR:L+F6*<HQD"9IY-9&*W!D'\4`BZ"L<"YFH"52SP5"?+<&
MN:1M%VF#9]'!PK!-:TS"2].:>?<=GA_E5%N at M?"P!PIJ<+T,[BVJ&]NHN+8Y
MF>!X^$0T%[60YKB\H'%GV(_01+MSYJ`P!=B,)5<W`'"%`L<V:&6J?F4DG#;3
M]7EAEUB>:!5B4R2\_H7`$V2B)T'J!`F-0H26ONT at Z&P.J at 3E85P3G2AA-Z:-
M##^%0%).2).-:?*`FE at PLE]1]@G5-.MM.3>J>?KVP?XAVSX0'HXT//)U$V'W
MZR;"UTV$KYL(V1/D"9L(:1C at JQO]S^Q&5P[+]0.0FG)9X?$V8I"YY:M-PV:Z
M92V<;TIB$R47XO!,@*C%'P,X7+3D0K(!%AI<-U/KWBDS"@Q5A(9;3,;Q'DM]
MJN,_,$B>S?'_%_*2P_]3+_E!K9%A4J[EB#$IU_($AF`#:K6V?-ANY#,I4RAE
M><KW640*?HC9GL^D9&FZJ9I6C*WIQ;%DNM9?C'&6&K93-18FEGCQVYNG*Y[T
M#,/TJP?YK^I!WJ:3>#,;,L4]_.0`CF=V*F][>B9[H"M)IB1CP?7246]LXR/9
M+VBT-7)8E9GEN`N8PD]VH>_^P^'>(MOZ at .:(YC*+9&8144`\#7U`J\'&;VA!
MX$+Q#Y=9%DRM'K8(HDN-9EE$@:)@]"[[7;AG^2;&W"![`_KG(YQ94U2QT.6T
M8$3.Y$O;A.]!:7*W,ZE'3*843+"&ALMMMBTXFRNIX12X,ART1$@.W$VT__#W
M#3+MO$W\NHS1S^.-3'09PJ^_>FG@);Y[_Z0`C$+!*Z4.>L/>B,^UP&]7X#\)
MWKO,`%Z*OHIDN/BAF]'`(*Z7MY#]6O%>Q\?ZAL-!DL.!,?%SN(>AF(G-7(U;
M\"DF.@\WW"TH1T7YRPS3?&9D2\XR(R,Y8LW(2)[-#VAD4,IA1C;8WA1]U+\\
MXB+LL%R)PZ`&QC]53?MC5HA&RNY$4"K8IN!%!%C>.LR`K1FF?KR$_?$+ at C&4
M1J/<I!VG^H''0VP"]IXV370+A\8V%PMLK+5TV3Z*K=]6%PN]^@$UBC&E/QD?
MR)+7"\SO2[W<_JAMT0SWMM14U5O.V/[:;V..)U4NS/(CYW&N'YGT^[DM],1A
MV,12?ZJ=GC@,*?;Z']!:?_Y at CJW.HU2[^^FAXX7C7O>T,^BI)Z<7;SJGZG%G
MU%$O1R+,8_.-^`3K?UQY158\17#D-?R3BXBP#R],YM^&<#S>:,MI:!@`6[B@
M-7^!%KB->8UH3`AFU=WIGDD1(;K-K1RV-BH<#"BMEH<&8LL8#U2HH at 21`,]J
MX-?JK3+I^P/O,!)FG#$53N$L*BX4N)I\0-[8'T-8(Z4FJ1`S)4M\@,E2I?5)
MK#_.3_CEESWQC22=HE;H&$&AN)N8KQ1'@PZ;B7$^Q)XTT0BA%4P67=K^^O/7
M\7!O`L]R0JEB]!PHP90-Y[V'FA+PTN\#%7_&<<.?<#>[9QWUM'NLONMU!J,W
MO<XH*6-D/.*`6_0\[VI[8BN+QO9'SHE[0"XTF'%DUB%H#`,W.L>,V>,/,D>:
M$CTM'&5"8J?7#\3GZF1F!)&(PF']6P_#R1+*S#'$DNSL.XRUY>26Y)6%(0%F
MX(9\S!'NRNH1[DK,$>[*TX]P9S$DY,&(Z3;*>L9@?TDD6"$Q$NP9M\_^M+Z+
M/^4>6E945C1#G.LC,2;K@#P?2JO=7/=7Q'H^GGS2A*PG"7^WMG+0Y&#MH`E_
MF,>]P2+$9&9JU at Y%>[;(V4R7Q>]X*$6$,7<OST(&^YVAT[4)WI$01T0<LTM%
M9.;KH$AJY5G&Z>M>X=>]PJ_>A[C)\5R>ARTY%[9YDF3\)2=)^+%XAF2EYGYH
M&[&+F<W)$N5B1=T)NOIBID;']KFW"NM*HURC5:=Y6%::SZ)/\QYD^3+0#:F@
M^XO/DW\]ZQ)[UJ5>/V2K<6W?LUJ^-::.\87G6_S8RK_.*9>HGR4.'C_I)`P4
MC0?=0/:<OC^[."\]]\$8[.,\-'ZLT at VVV[ETI.>75PMP4=BB5R75#P';\4/$
MG at 9*/PF4=5HH%;,_PTK_QP+5<:>)M at Q_<T#?Q4)OI$+?F`Q1Z!N3)>:2A1S0
M-YE0CM-(36:<U)O;QYI\*#?9(O_MCQ5M#CKWF974K/NKW#.%%N2/5?U]3CQY
M\',[!YX at 1ITV&G*)#RP,+P?GXK3RF`X?8Y+'D`.%KA256G5?@-G20J6BMUT1
M0<@/[7_'XU4>VMW6Z2I(J69ANG'5,$LT6 at WFC:V&GSE!`'$($C)$X<&&G[WI
M0<Q8YX5 at Q9.P^.\$Q;=Q].L9%.PSW!^7'@1`9%%)4 at 12S+0`[K0.XS.R0Y>N
M-2,I9*C*-J:6-N;7023@<G;=;2B6]TRS/W`8;G]$<G1M at 6&P)*X)E,,&WZ)O
MROX6O?T1.XW"/YUZ.\[%?_6ZYU=GZE6_JYQWR[`T=260@#+C4V;!I'(AO,+-
M:'&?B7?L:N5D&7<"DUO_LC\J>79UAJC'7)S,EO%6C5TU0"A>W"OQ'(+V5]XX
MS]@WE_T3>QFH.#@0^*57Q2ELWX_?Z^LCBD8(443ARF][F]L?!Q/\R3?:P#.`
M/*GH7IR==<Z/A[B"<*1W3%=EE;9>-?ZD0QVQ3U75F;O2$3?_JWX0;X!#LG*&
MP4]67GZILWS`+G5&\++?EIOI*"@/Q7Q7?[=D=O4W?HC+G?F$]1$W<FBH#GN#
M?N>4Y(6N0^VRRF"&HF/8/!S`,6Q31/QBDQQKRL3(!PM1HBLPON`;2_SF)+3L
MQ$L.R/*=ZF,D:<]1_DDP?4H)MY"#)UA8R]D;M=NY9$+E?U/?GG:&[TH,!SU5
M$FBW,Q<K*&-..:"L6Q4#CV`^*:CQ"^!KK6>1 at E6>,5K]\^/>#P7E-Q6-W()!
M`!DM:N<6[1C3P:78FHM35'Y?-Q.>Z3W;3D]FG,B0)BPB2Q`LT`)9:<MRNU;;
M3$A6">40#J7.A`,_A'`LR1%:((Z=7G2.A^J;SM6QVGW7.3_I,?\&/U:&AHAU
MCPO:<LP.C7$T6Q"A!IQ7A<@*7B at H5-YW((J[N`J%$']9O?[1I;>#WC_%K<LK
MCE16B6AGU&G-VCCD%[21#]LSM`J\<1MQ]N*';AI?67(:5UD&WPLF-T$Y8$=?
MY,UX&B:3S=$&F^V-M<F^QHRUM)4S7DGI;RXN1NKEX.)DT!L.0<F<F9@%\FH)
MGD@"-^B,4-H.6]BG5(Y-S6N53GS$NR[C4L/\BDLO*(?[<D56\!_%Z^`4E#/>
MP1!+)2^WY#)A/$0Y;)-20OTDH7XJ=DNH at A>/MCFY=8%HL<<G4^,:SC576UAW
M\/UDSO]Z/;/O]G1K]HKRL'Q#`U4JP9KNH'?<'PV9?IVBLJ,]EH5A(<A`T&*1
M'G=M\WKI<H2!QJ+#RB]LZW\,W=WS"8XPA9Y.;&U&Z)>P*CC6C7NOV<81/%I+
MQ$)S-*%QM at F*8+(3J57+9A1F%K+MD1[2O+69QL7AFCG4)/IR<GX%)^P,ZA0N
ME]=34X=34S?FN!AIHE7TU+G%MEX_LB)OJ15#T0IXBT![S'#3$1 at FZ7*@@_R$
MHVI8"2-!I035,M#[2S27&H]H;4$%2]CB1T!(&)1-'H. at J\R)1Z1OK06%ZB-1
M[.>]29M9!BVG-\MIF='`W/"^/WIW<36"SOF/\+XS&'3.1S\>,7Q(QYB,.X$E
M"0J:!"XUV];F[J/7A;/>@)3QJ/.F?XK3C'KQMC\ZI\GX%F=;!RYQ>>UWKTX[
M`[B\&EQ>#'M[P"0"J7(I2AYIDI,9.97&AJN94R?H_8_(8@=;.!W#K79'4%0W
MS#MLGX92M'C,YB*CHC&,P["P&QK.(_)N(5 at IP[UMHN at P68SPEY4/>%Q&K*KO
ME:%Y"".#4#-<3C4=N3I<$H5Z72[#&\MQ,2<?M@[.9H5>K5*7]^%JV*&GN.[0
MVVK6`^.DE)@V*3YH+N6U6DDG^8+7UF2^?F=E`S#A-3REHYSO-N+US;TW2JTL
MMR%]OK82AS<_PXT7;<OVSE$+PQW)A7%+['U3T=?VK&^^;'"E6T`O;S2<]`GE
M1?S$[$I(06K.V+A0B?`>A?0YOG&9(7+4P)PA<DEUI(;(,?HQWE$IIMJ$$#G)
M]SR(HJP=J;U-"I%CK2&#GW\KY`R7\VI,=]$SXED'BQBE37ST4L;5&FQ\$\+E
MI'"#HFYZ*<--SYN:$N#&QA*3D0SS4?N"21.*/-0T+9V%H9LWR";_.G.Z9A?^
M5NQ>7I56S:_=:H$W"GL1IP^^BXMI\5XIA\480T6?_#:E1\1(.3 at 6&B at ***@O2
M_<!2O$LN,4SJ$_>^/6WLL&RL6F2TQ5ADQ0_E&*T5;ZX4^\ZV_/=2)+W.;67Y
M"+_4+>9R"F_IXG(7%R6R5G&PEB4LO)X at IT9`K:^9JQ%0>5;G]14YO8;85?FS
M+V at ***@F5%&Y9"527=&L6(HK.E1IK"LZ6JO+BN2"9&?:!X.!D#6 at Y*7$03$O
M+7"7-4!1V*OP#M-1<QR%O&_FV&<OYN"`N7/QYC^'A9>`M,C`GT_VT!I%J7'V
M+$*R79','$68]#-M=>%PH at ZXQZ^ZIM\:^(EF#FEZ_.O#9'S-2,SP&PYG_LRA
:_2)>MZCZ;T76QA)I$/8'IOT?P?[1!V=W````
`
end
--
Gleb.
Wolfgang Denk
2003-09-18 08:22:26 UTC
Permalink
Dear Gleb,
Post by Gleb Natapov
The attached patch moves most of the things related to timer interrupt to
ppc_lib/interrupts.c leaving only cpu specific code in cpu/$(CPU)/interrupts.c
I only checked it on MPC8245. It works for me.
Can you look at the patch please.
Move most of the things related to timer interrupt to ppc_lib/interrupts.c
You do much more than just this. I appreciate most of your cleanup,
but I have a few requests:

* Please don't create a new (and undocumented!!) config option
CONFIG_ACTIVITY_MONITOR - we already have CONFIG_SHOW_ACTIVITY
which serves exactly this purpose. I see no need for a new option.

* Instead of just collecting common stuff in a common file you change
interfaces here and there. Can you please describe these changes,
and the reasons for them.

* Please keep existing Copyright notices in place.

Can you please rework your patch and resubmit it? Thanks.

Best regards,

Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
If you fail to plan, plan to fail.
Gleb Natapov
2003-09-19 09:03:06 UTC
Permalink
Hello Wolfgang,
Post by Wolfgang Denk
Post by Gleb Natapov
The attached patch moves most of the things related to timer interrupt to
ppc_lib/interrupts.c leaving only cpu specific code in cpu/$(CPU)/interrupts.c
I only checked it on MPC8245. It works for me.
Can you look at the patch please.
Move most of the things related to timer interrupt to ppc_lib/interrupts.c
You do much more than just this. I appreciate most of your cleanup,
* Please don't create a new (and undocumented!!) config option
CONFIG_ACTIVITY_MONITOR - we already have CONFIG_SHOW_ACTIVITY
which serves exactly this purpose. I see no need for a new option.
Yes CONFIG_SHOW_ACTIVITY is exactly what I need. I didn't find it first time. Thanks.
Post by Wolfgang Denk
* Instead of just collecting common stuff in a common file you change
interfaces here and there. Can you please describe these changes,
and the reasons for them.
I don't quite understand what interfaces I changed. But I can explain how I see it working
now.

There are common interrupt_init() and timer_interrupt() for all PPC archs.
interrupt_init() calls interrupt_init_cpu() for cpu specific initialization.
interrupt_init_cpu() should set decrementer_count to appropriate value. If
cpu resets decrementer automatically after interrupt (ppc4xx) it should set
decrementer_count to zero.
timer_interrupt() calls timer_interrupt_cpu() for cpu specific handling.
If board has wahtchdog/status_led/other_activity_monitor it works automatically
from general timer_interrupt().
Post by Wolfgang Denk
* Please keep existing Copyright notices in place.
I hope new patch contains proper Copyright notices in place.


begin 644 interrupts.patch.gz
M'XL("$O":C\``VEN=&5R<G5P=',N<&%T8V@`[5U[=]K(DO];_A0UF7OG@@$C
M\;*-)]D03!QV_;J`;V9V9HZ.+&2L#2`B"3_N3/:S;U5WZX'0"P?/(QN?Q!BI
MN[JZJ[KZ5]75TMB\N8'*TCZ'R@\PMN;NF"XL*]>6Y5:O+<T>5W5K8LS=ZE0?
M[^GBSMXBYMY.I5))KBG59+E>D5N5V@'(<KNNM)O[>[+W`R6Y+LL[I5(IK05!
MX["B'(*BM!O-=J.Q1N/U:ZC4:H?E.I3H0]F'UZ]W@'[,&RB42K;E:JYEJ^9\
M;#S`JY=0<,Q_&]8-X`W]5K,=J$+DRD_R+\7B#DBK55^"?+0#GW9*.Z5OS9NQ
M<0/=B_.W_1-U^.[BO=KICOK_ZH]^W"G=6>886&=4Y]:Z5S7=->],]Q$*RZDU
MGX!KS at S'U6:+XD[IUS5:H\[H:JB>]HYW2A)UH.`7A[]#H?OV1'WWW\AQK0 at O
MD2$D(4DX5NJMH=GNM:&Y4"@>(5%CCH+=*3%N&4,KK!3,N0N:/>$<?/++C[.U
MX_9Q9HG?Z^JQ<G-=/U9N!PHB at UQK-TA'\BA(')%L#6DJ==(0^J at UF8:0?`UW
M:<^A(!>W)MAKS3%6Y4H2^_'LXE@]?H-2':+`[JRIYII3`\S93%NH+NSB'S;J
M5\&_4&3U^F=G at Z.5"M;BH-:2615K at 36^HYJ55^9,Q>^6[5)I5!;7U(%$[-R:
M-RY7W%*</G%U$JH$OY(R\4G#*[Z".E,P*4P'BU at +;-):J(NQYH[A)2LB%2*7
MOX/_E1_D&RZ)(OP&!06^_QX*M0:4.&-%TE3)USZH[JZ-%NQ6-U5B1B9&?D0J
MAWY;#SK]7]=M_\:Z7ONWA#K6*DH#E'J[5FO7#U?4L1:OTU$"V?JL-%OE%I3H
M0ZDQ?9:FQMBU)I.I42HQ=8:-35&:P5'D8LCD(+,J;XS3-+!Q;GE(6)`F+%0S
M\'1T.7?,R1RKDMD%HL%T+%5,^F)9W6\\/*C[#P]5I&K8]G+A.F&!)18)BRZQ
M$,D`):@P&=3;<J-=D].%F$HJESCKM7*K!B7\X,O7M^9<GR['!GRO6[/9PK;T
MO=M7T<O:?,RN[E2JNUO\J>Y4=BJ^9,:&;ALS at SJEZM9R[AY);''%6<:^PITV
M71IP8]F@&*TJZLK,U&W+,71K/G:`4]L^?T*!5%R;I^;<4-5`ETBS=RH3PU5G
MCET at 52SN5'[=J4 at K)0!O'A$E27-FX%G8PHO9#=Z`O\LOH`TO7MHOH(#?B]!&
MW:YX"P:O^BF>#VH0KXOFU]H4O$0:=8-&L5FOU6)R*S&]14DE]Q:E%-];K+72
M6RP8Z2VOROA([R\QL-9J0G^#9D5_J6 at Q:(=3->;:-9J88$J%.RB&&`J>J&F1
M.1L.U%[/)X1:RGOAP,U4FQ`DY"7 at 7G,`*<"U@:IK,#W%9G8J8]-):7/IB1$-
ME=_L49 at 9^H5+7\"'CS+$+7$'OB%;&O"Y[0E"]M;O`_;&=$4_2NMW5#1@$(AN
M=VW.<ZN-B`;-P0V*?5PX[KVY.BG"=]_!-]XEL>AVSOHGG8OSWDE]V",0O;"Q
ML9O"B]4FVW`R at IEFSD'7EHZ!4IJT42$.'MKTZ^?YBS)?YF3$:V at 8&P?E`[[*
M`?\Y&0UZ)X->Y[C0&[WK#<Y[HYK:/Q_U!H.KRY%ZUAG^EXH%^D.\0FJ%;"Q1
MDFM,H-A<$R6ZUF/D@*H)7%R1U at H(!7"O]>D'U+RJP%*$:-;'+[$PVFZ!$]F`
M8D/I?.)RNM2F at ETLPMFL^&R*:<CG1+2Y(K,`T?82Q,.F'C493`2NW"])3-.'
M(I-119+\:;#&2,KDS,T&KO[&WGK#$-?J&J`'KD,-I=S`Q7:_5E9D[ASNPLA&
M6((C:<X64R8JM$S6'"HPMV!NX"1P+30-J);:=/J(PZXO;<TU]JAN=4?8/`)*
M=F`H"HYK+W47D'?49ESZZ'?(5I%Y7)]99"%\Q$7(C8\-1&;5^\ZH^^[XX at 3I
MI;N%`9B/(W/9[5]>=FM$13(>D(LYQVH+W5PL])IZ/R;FR2YR:\'7#&GM=F%%
MV)^\OT/8VV.86=9GLG%<#(PAE0DC;*J#`6*8DO.P#)9+7H$;=.ZUL6J>"@75
M*_RV1R)8[\(4T$26(OK`K6J\4D"40^:YX>C-+?>69AVJW]B"6X,O327!EM!J
MV/)09N+MV4)OIJ+MF`)1K!U3)!HC0G>IGAX"2">4(U!T4%;0;<*/0V$)JC2>
MJ[C:FA.LK at 07[S57OQU;DP@&YXQ$+B+0J1)>-QS'LK<-SS.A>3Y4+FT9E1,U
M$(H>J#^Y?FA2R=T++MZBTS)%?EW8%7_2XLQLT"ZZAT=,2HU6>;^.WM!A6>%B
M$J at SJ0G3_JC>&;KST_E`[0_^.?SEB$^2G0I:^E-+1SM_LYSSLB@;UW(?%X9#
M=ZN9V-I;:6!#3P)"KD0[<"3:PJ3F]23`7TCS>!(0<B7:[8W]")AX\&$S/P)"
MCD0[<",B?<WA1X"/7_+X$1!R)$1O5[P(H0`]YD2$<(P0/&MPS<.`-!<#XGT,
MULP at CY\AFB8(ONYH0(:GP0(LE6TX&PP"]1%@(00RG96Q$28QQG^`3`>"L9SD
M/6P:]J0`+9JSXX`:H*,PYFLB&392H:7#HD8TIND0'3;"Z!`!Z9P3+C!`1!@&
MQ31<DA^&=<PEDIO?[#DZ_CW3G`]BWR`,SF-18+:Z)>#;FMPB.UE2&LVRTN!>
MDF\1\=<O>VA8D8OSJ]-34:WBRR(2!Q18B1E/TA$8$:8)NHM@"'EST&F;TKC?
MWQIS@&O4#1DL`O-=BN3-)P9.`]N:<1+RWHH034=,.JQNNK>L]NA-#]O`CV%W
M(#`VGYX12)4$ITIQA3/PUQ,4LI*X5U-90=-<,U7L(F)$_8.8&6%/A:"Y[#O'
M:,AP%15CW?<[2]?"7BC?Z=HO-_91V"VES/<Q)%5%HX@&M/!B;BU8^4`=49=M
MQ]W3-5M=3!>V;L-O+^'R]'+0':BCW@^70]0O[^L9>LM<4:MDS1R7XB)AR779
M-&%S+5.58UR:I)%;&ZT@*GT4XU@$=45P,<-;(O,LD<=W:U!(VG:1-GB(#A:&
M;5IC4EZ:UBQ4[O#RJ*?:`M'"PQXH:,'U,KBW:&YLH^+:YF2"X^$3T5RT0IKC
M\HK&G6$_0A-QY\Q!90I\,W:[NH$#)TG<MT&4J?J-D7+:S-;G=;O$\D2K$)LB
MX?4OY#Q!IO<D2)T at H5&(T-+'#H+.YDZ5H#R,8]&)$G9C>&3^4\A)RNG29/LT
M>9R:6&=DOZ+LDU?3K+?EW%[-T[</]@_9]H&(<*3Y(U\W$7:_;B)\W43XNHF0
M/4&>L(F0Y at -\#:/_E</HRF&Y?@"EIEQ6%(X\^2!SY*M-PS#=LA;.-T6QB9++
MX_`@0!3QQS@<+B*YD&Z`A8#K9FK=.V5&@7D5H>$6DW&\Q^X^-?`?`))G"_Q_
M05%R^'\:)3^H-3(@Y5J)&$BY5B8`@@VHU=KR8;N1#U*F4,J*E.^SC!3\$+,]
M'Z1D]W13-:T8K.GEL62&UE^,<98:ME,U%B;6>/'[P].52'H&,/T:0?Y2(\C;
M#!)OAB%3PL-/3N!XYJ#RMJ=G<@2ZD at 0EF0BNEXYZ8QL?";\@:&OD0)69]7@(
MF-)/=J'O_L/AT2+;^H!P1',9(IE91!30GX8^(&JP\1LB"%PH_N$R9,',ZF&+
M7/12HUEN<0R%BM&[['?AGI6;&'.#\`;TST<XLZ9H8J'+:<&(@LF7M at G?@]+D
M86<RCWB;[N`-:VBX'+-M(=A<24VGP)7AH"52<N!NHOV'OV^0B?,VB>LR03]/
M-#(Q9`B__>;=`^_FN_=/2L"0)*^6.N at ->R,^UX*XG<1_$J)W,4RN)#2S[*M(
M at 8L?NAD,!GF\G$/V:R5Z'9_;&TX'24[_Q9N?PCT,Y4QL%FK<0DPQ,7BXX6Y!
M.:K*GP=,\\'(EIP%(R,E8F%DI,SF1RXR*.6`D0VV-T4?]<_/N`@'+%?R,(C!
M^*NJ:7_,2M%(V9T(:@7;%+R*<):W[F;`UH"IGR]A?_R,9`RET2 at W:<>I?N#)
M$%G`WM.FB6[AT-CF8H',6DN7[:/8^FUUL="K']"B&%/ZD\F!D+PNL;@O]7+[
MH[9%&.YMJ:FJMYRQ_;7?!XXG-2Y@^9'S.->/3/K]W`@]<1 at V0>I/Q>F)PY""
MU_^$:/WYDSFV.H]2<??34\>EXU[WM#/HJ2>G%V\ZI^IQ9]11+T<BS6/SC?@$
M]#^NO"(43QD<>8%_<A61]N&ER?S;$(''&VTY#0T#((<+6O,7B,!M+&M$<T*P
MJ.Y.]TS*"-%MCG+8VJAP9T!IM3QO(+:.\4"5*DJ0"?"L`+]6;Y7)WA]XAY&P
MX(R9<$IG47&AP-7D`\K&_ACR-5):*DDQ4[+(!YB0*JU/8OUQ?L(OO^R);Z3I
ME+5"QPBDPFYBN6(<#3IL)L;Y$'O21!!"*Y at LNK3]]>?+B7!OXI[E=*4*T9.=
MY*9L..\]KRG!7_IC7,6?<=SP)]S-[EE'/>T>J^]ZG<'H3:\S2BH8&8\XQRUZ
M0G>5G]C&HKG]D>/AGB,7&LPX,NLN:(P`-SJ9C,7CCR9'6(F>_XT*(;'3Z^?@
M<W4R,X-(9.&P_JVGX60I9>888DUVFAW&VG)R2_K*TI``"W`@'W,HN[)Z*+L2
M<RB[\O1#V5D""44P8KJ-NIXQV)^3"28E9H(]X_;97S9V\9?<0\O*RHH6B`M]
M).9D'5#D0VFUFZU\D8\GGS0A]%3"WZVM'#0Y6#MHPB_F"6^P##&90<W:H>!G
MBY+-#%G\@8=21!IS]_(L!-CO#!TA at G\DQ!$9Q^PQ(3*+=5`FM?(LX_1UK_#K
M7N'7Z$/<Y'BNR,.6@@O;/$DR_IR3)/Q8//-D2\W]T#9B%PN;DR7JQ8JY$W3U
MQ4R-CNUS;Q76E4:Y1JM.\["L-)_%GN8]R/)Y3C>D.MV??9[\ZUF7V+,N]?HA
M6XUK^QYJ^=:8.L9GGF_Q<RN_G%,NT3A+G'O\I),P4#`>=`/%<_K^[.*\^-P'
M8["/\]#XL48WV&[GVI%>7EZMP%5ABU&5U#@$;"<.$7L:*/TD4-9IH52?_1E6
M^C^74QUWFFC+[F\.UW>QT!NIKF],@:CK&U,DYB$+.5S?9$(Y3B,U&3BI-[?O
M:_*AW&2+_/<_5K2YT[G/4%*S[J]RSY1:D#]7]8\Y\>2YG]LY\`0QYK31D(M\
M8&%X.3 at 7IY7'=/@8;WD".5#*-05*K;JOP&QIH5K1IUT10<COVO^!QZL\;W=;
MIZL at I9F%Z<8UPY!HM!DL&]L,/W."#L0AE%`@"D\V_.1-#Q+&NBR$*)[DB_]!
MKO at VCGX]@X%]AN?'I2<!$%DTDI2!%#,M@`>MP_X9X="E:\U("YE791M32QOS
MQT$D^.7L`;:A7-XSS?[`W7#[(Y*CQQ88!KO%+8%RV.!;]$W9WZ*W/V*G4?FG
M4V_'N?"O7O?\ZDR]ZG>5\VX9EJ:N!!I09G+*K)A4+^2O<!@MGF?B';M:.5G&
M@\`4UK_LCXH>KLY0]9A'(;-EO%5CCQH at +UX\5^(Y%.U+WCC/V#>7_1-[&5YQ
M<"#P<Q\5I[!]/_X<7]^C:(0\BJB[\OL^S>W/XQ/\Q3?:P`-`GE9T+\[..N?'
M0UQ!N*=W3(_**FZ]:?Q)=W7$/E559^%*1SSP7_63>`,_)*MDV/G)*LL?ZBP?
M,.>ET6[NM^5FNA>4AV*^1W6W9/:H;OP0#W?F$];WN%%"0W78&_0[IZ0O]#C4
M+FL,9J at ZALW3`1S#-D7&+[+D6%.F1KZS$"6ZXL9+/ECB3TY"9"?>;4#(=ZJ/
MD:0]1_TGQ?0IQ3T$'SRMPB;.WJC=SB73*/^;^O:T,WQ79$[04]6`MCISR8$*
MYE0"*KI5'?`(YE.!&G]:>ZWU+"JP*C!&JW]^W/M!4GX_O<BM%>0:(Y9V;A'!
MF`XNPM9<G)_R.[J9YDSOV49ZLM1$@31-$46"-($6R$I;EMNUVF8:LDHHAV8H
M=:89^"$T8TDA4(G$=7K1.1ZJ;SI7QVKW7>?\I,<B&_Q`&4(0ZQZ7LN68'1?C
M?JPDD at RXH*3(VBU)"M7W0X?B*5R2%!(N:]<_M/1VT/NG>-[R2 at B5-2+XC(:K
M&8]#_F at VBEY[$$OBS*5*=FI>JW1R(#X$%G<W+-.X^Y)RN"]79`7_4=X'"E3.
M>)9_+)6\TI3+Y"L at 6F;.:@FUO83:7N at 6<38O'FUS<NOB^,ERA2P1N_?>FMY,
M4'9P;,P_E.&X=_X##*T;]UY#F-";3U`F..GGDS+<CU^/C?G#WA at 1)]:,IUQG
MET^FQC6<:ZZVL.[@^\F<__5Z9M_MZ=;LE5]]:."\)^#='?2.^Z,A,P)3G)2T
M"[`P+(3!"*LM,C:N;5XO78Z!$<XXK/["MO['T-V`GQ'>H:L36YN1?T;>%#BB
M.T?P:"T1K<\1Y*%6"(I at LC.35<MF%&86*L0C723]LIEE0$','&*)OIR<7\$)
M.R4YA<OE]=34X=34C3E:3$UP15>=6^3U^I%5>4M<^(/Z%EW!,4/V1V"89'.`
MCIH3TJ]A(XP$U1)4RX!C4M!<8A[]B055+"+'CX!.2U`W>0R"KK(P$Y&^M1:4
M3(Y$L9_W)FVW&&3S;Y;3,J.!I>%]?_3NXFH$G?,?X7UG,.B<CWX\8AX,';0Q
M[H2W0\Z*2>Z/9MO:W'WTNG#6&Y#1&'7>]$_I[2?8B[?]T7EO.(2W%P/HP"6N
M`?WN%3KD<'DUN+P8]O:`:012Y5J4/-*D)S,*>XP-5S.G3M#['U'$#G(X'<.M
M=D?.DFZ8=\B?AEJT>,R6(J.B,13.O#4W-)Q'%']!.(V3P391=9 at N1N3+Z@<R
M+J,WI>^5H7D((X/\.KB<:CI*=;@D"O6Z7(8WEN-B23YL';03"KW\HR[OP]6P
M0U?1/M+[?-93MTHI65>E^+2NE/<])9TU\]_FE/%^HI7]J>2WOA2/\KPJAS<V
M]UYAM+(FA+#`VG(1WIL+<RYXRPX>$7OACN1RP8KL!4?1M\JL[PUL\,2Q@%[>
M9*W2KZ at LXB<F:%X*[N9,W0K5"(?0^0N1GI#!10SFS.!*:B,U at XO1CPG>E6*:
M3<C@*OF.L:C*^$CM;5(&5\E[HQ'_)N7,YO):3(\@,^)9YUX8I4U"R*6,)S^P
M\4W(YBJ%&8I&D4L9463.:DK^%1M+O(UD6`C55TR:4!1`I6GI+`S=O$$Q^4_;
MIJ?`PM\*W<NKXBJJVZU*G"GL19P]^"XNY<)[AQE68P(5??)Y2D_8*.606&B@
MY. at L2`]3EN(C1HE9/+_RX-#3Q@[KQII%1EN,159Z2X[16 at DV\@7AZ8]-2'J[
MV,KR$7['6,RS$[QUB^M=7!+#6L/!6I:PZGJ*G)J@$[- at KB3H9"[-L<MQ1 at MK
M2W+P(KR8,"G3J*A2LAJI85)6+25,&G[[7ER8--JJRZKD<O/.M`\&<S_6G"_O
M3IQ[Y]T+HCD-<LKH-6V'Z;YZ'(6\;XW89R^-X"YZY^+-?PZEEX"T"-K/)WN(
M0U%EG#V+/..NN,U$CK=^IFT8'$XT`/?X5=?T6P,_$>.0F<>_/DS&UXS$#+_A
?<.8O'-K+X&V+IO]68#P6R7RP/_#>_P$",56Y^G4`````
`
end
--
Gleb.
Gleb Natapov
2003-10-14 07:07:28 UTC
Permalink
Hello Wolfgang,

What is the status of my patch that combines common functionality
of timer interrupt in one place for all PPC boards. Is it rejected, accepted
or needs more work?

Thanks,

--
Gleb.
Wolfgang Denk
2003-10-14 20:28:16 UTC
Permalink
Dear Gelb,
Post by Gleb Natapov
What is the status of my patch that combines common functionality
of timer interrupt in one place for all PPC boards. Is it rejected, accepted
or needs more work?
Let's say it's on hold. I think I will accept it, only not for this
but for the next release.

Best regards,

Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
"We don't care. We don't have to. We're the Phone Company."
Wolfgang Denk
2003-12-06 22:30:48 UTC
Permalink
Dear Glab,
Post by Gleb Natapov
The attached patch moves most of the things related to timer interrupt to
ppc_lib/interrupts.c leaving only cpu specific code in cpu/$(CPU)/interrupts.c
I only checked it on MPC8245. It works for me.
Checked in. Thanks lot. And sorry it took so long.

Best regards,

Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
The Wright Bothers weren't the first to fly. They were just the first
not to crash.
Ronen Shitrit
2003-12-15 16:30:00 UTC
Permalink
Hi

Did anyone try to add support for interrupts for the 74xx_7xx ???

Thanks Ronen
Post by Wolfgang Denk
Dear Glab,
Post by Gleb Natapov
The attached patch moves most of the things related to timer interrupt to
ppc_lib/interrupts.c leaving only cpu specific code in cpu/$(CPU)/interrupts.c
I only checked it on MPC8245. It works for me.
Checked in. Thanks lot. And sorry it took so long.
Best regards,
Wolfgang Denk
--
Ronen Shitrit

M.S.I.L
D.N. Misgav 20184
Tel: +972-4-9951000
Fax: +972-4-9951001
Email: mailto: ronen.shitrit at il.marvell.com
_____________________________________________________________
This message may contain confidential, proprietary or legally privileged
information. The information is intended only for the use of the individual
or entity named above. If the reader of this message is not the intended
recipient, you are hereby notified that any dissemination, distribution
or copying of this communication is strictly prohibited. If you have
received this communication in error, please notify us immediately by
telephone, or by e-mail and delete the message from your computer.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20031215/7db87a55/attachment.htm
Continue reading on narkive:
Loading...